Do the 10gbe devices need to cross between vlans, or are they all on the same vlan?Upon re-reading your post here, since I have 10GB devices on my LAN (NAS, Dell Server ESXi w VMs, two PC Computers) - and have not yet set anything up :
Would best practices for me be VLAN setup and intra-VLAN access to be done on the Brocade 7250? and then the PfSense box is acting only as Router, plus some pfsense packages like pfblockerng, Darkstat, Suricata. In this scenerio, where does DHCP Server run? pfsense or Brocade?
If they need to cross, you want that to happen on the brocade, this would point you to the exit vlan approach. If all 10gbe traffic is on the same vlan, it doesn't matter which approach you use, as you don't need 10gbe to the router.
I'm not sure about the "right" dhcp answer; I've done it in the switch although with an Aruba, and with Opnsense. I found both of those hard to see the clients leases.
I most recently moved the vlans extended to the router, and do dhcp for each vlan on it. I found that simpler. That did not require doing dhcp relaying.