I have no experience with XFP modules but I figured I'll respond anyway in case someone else wants to weigh in.
From a cursory glance, it looks to me like that should work.
Note that the older Intel NICs like the X520-DA2 are built for high airflow cases like servers as far as I know. If you use it in a desktop/workstation you might have to add a fan to the heatsink, and some are even sold with active cooling from the factory.
The Intel NIC can also be unlocked to support non-Intel programmed transceivers if you want, but that one from eBay already looks to cost about the same as a generic one anyway.